Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency changes
Implementation changes (OSGi specific)
factory=true
withsuppressMetatypeWarning
properties to generate empty OCD. Such construct is not possible with DS and I am not sure what purpose it had. Those properties were removed.service.pid
based on component name. This property is used on a lot of places in service lookup / filters. This approach is not possible with DS (see FELIX-5304). Service PID properties were removed where possible, however additional cleanup is still needed.Bundle changes (metadata)
Bundle-License
manifest attribute. This was not an intentional change, but it probably doesn't matter as CC-BY-NC was for docbook documentation.Import-Packages
configuration. Seems to be in the direction of best-practices and should be ok.Known (unrelated) issues
master
branch is broken due to JwtSessionModule and AbstractJwtSessionModule are incompatible when handling Max-Age cookie attribute wrensec-commons#22 (not caused by the upgrade).