Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotated map interpolation #1349

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

l-althueser
Copy link
Contributor

This PR adds functionality for pattern maps that are saved in rotated parameter space such that the input coordinates need to be translated. In addition, a new (slow) interpolation algorithm is added which only takes the inverse distant weights in 1D for each row in y-direction.
We will need further confirmation from @andrieub and @odadoun if this is exactly what is needed from their side - lets discuss offline but keep this draft PR for communication.

Thanks!

@coveralls
Copy link

coveralls commented Mar 21, 2024

Coverage Status

coverage: 91.148% (-0.2%) from 91.317%
when pulling 9bd9c41 on rotated_map_interpolation
into fb1ae76 on master.

@yuema137 yuema137 self-requested a review March 25, 2024 21:32
@andrieub
Copy link

First test of rotated map interpolation using 1D algorithm in fuse successful, see
https://xenonnt.slack.com/archives/C07GXK1KH36/p1726237489137709
More tests needed, especially on timing, but it looks promising!
A small correction @l-althueser comment: 1D algorithm should work in x-direction, not y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants