CNF posrec urlconfig fix #1519
CNF posrec urlconfig fix #1519
Conversation
|
This PR needs this one to be merged no? |
|
Tests are failing because the test environment does not have the latest xedocs version; relevant base_environment PR XENONnT/base_environment#1927 |
Yes, and also the base_environment PR |
| @@ -57,7 +57,10 @@ class PeakletPositionsCNF(PeakletPositionsBase): | |||
|
|
|||
| pred_function = straxen.URLConfig( | |||
| default=( | |||
| "jax://resource://flow_20240730.tar.gz?" | |||
| "jax://resource://xedocs://posrec_models" | |||
There was a problem hiding this comment.
Will this PR only work after https://github.com/XENONnT/corrections/pull/314 is merged?
There was a problem hiding this comment.
Yes. Currently xedocs hasn't been synced anyway, so it is also waiting on that. I told @LuisSanchez25 about https://github.com/XENONnT/corrections/pull/314 so he will wait till that is merged before syncing
|
@dachengx do you know why these tzinfo test failures are happening? They aren't related to any code I've modified |
|
I have turn it into review mode since pos_rec map schema has been synced |
dachengx
dismissed stale reviews from LuisSanchez25 and sebvetter
via
c8292b9
|
Thanks for the fix @dachengx, seems like tests are now just failing on some python version issue. |
Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
What does the code in this PR do / what does it improve?
Close #1518
Close #1506
Can you briefly describe how it works?
Changed the urlconfig string to use xedocs.
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:
Notes on testing
All italic comments can be removed from this template.