fix failing assert in connect
RPC
#5235
Open
+62
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR fixes a failing assert scenario in the
connect
admin RPC.Context of Change
When a node is in standalone mode and someone with admin access tries to submit this command, rippled fails an assert (and crashes in debug builds), regardless of what the other parameters are.
Example crashing command:
Type of Change
API Impact
N/A, fixes something that results in a failed assert before
Before / After
Before, use of the
connect
RPC on a standalone node fails an assert in rippled. Now, it returns an error.Test Plan
Tested locally.