code suggestions from rabbit AI

XRPLF · Jan 8, 2025 · 0ad5503 · 0ad5503
1 parent 76e5d09
commit 0ad5503
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 10 deletions.
diff --git a/packages/xrpl/test/integration/transactions/permissionedDomain.test.ts b/packages/xrpl/test/integration/transactions/permissionedDomain.test.ts
@@ -72,8 +72,6 @@ describe('PermissionedDomainSet', function () {
         DomainID: pd.index
       }
 
-      console.log(pd)
-
       await testTransaction(testContext.client, tx_pd_delete, testContext.wallet)
     },
     TIMEOUT,

diff --git a/packages/xrpl/test/models/permissionedDomainSet.test.ts b/packages/xrpl/test/models/permissionedDomainSet.test.ts
@@ -12,16 +12,14 @@ import { validate, ValidationError } from '../../src'
  */
 describe('PermissionedDomainSet', function () {
   let tx
-
-  beforeEach(function () {
-
-    const sampleCredential: Credential = {
-      Credential: {
-        CredentialType: stringToHex('Passport'),
-        Issuer: 'rfmDuhDyLGgx94qiwf3YF8BUV5j6KSvE8'
-      }
+  const sampleCredential: Credential = {
+    Credential: {
+      CredentialType: stringToHex('Passport'),
+      Issuer: 'rfmDuhDyLGgx94qiwf3YF8BUV5j6KSvE8'
     }
+  }
 
+  beforeEach(function () {
     tx = {
       TransactionType: 'PermissionedDomainSet',
       Account: 'rfmDuhDyLGgx94qiwf3YF8BUV5j6KSvE8',
@@ -48,4 +46,22 @@ describe('PermissionedDomainSet', function () {
     assert.throws(() => validatePermissionedDomainSet(tx), ValidationError, errorMessage)
     assert.throws(() => validate(tx), ValidationError, errorMessage)
   })
+
+  it('throws when AcceptedCredentials exceeds maximum length', function () {
+    tx.AcceptedCredentials = Array(11).fill(sampleCredential)
+    assert.throws(
+      () => validatePermissionedDomainSet(tx),
+      ValidationError,
+      'PermissionedDomainSet: AcceptedCredentials must have at most 10 Credential objects'
+    )
+  })
+
+  it('throws when AcceptedCredentials is empty', function () {
+    tx.AcceptedCredentials = []
+    assert.throws(
+      () => validatePermissionedDomainSet(tx),
+      ValidationError,
+      'PermissionedDomainSet: AcceptedCredentials must have at least one Credential object'
+    )
+  })
 })