Jshooks [DO NOT MERGE] #318
Open
+119,587
−1,447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger_last_time, ledger_nonce, ledger_keylet
…ubfield slot_type slot_float compiling not tested
… float_sum float_sto float_sto_set float_invert float_divide float_one float_mantissa float_sign float_int float_log float_root
Co-authored-by: Denis Angell <dangell@transia.co>
RichardAH
force-pushed
the
dev
branch
2 times, most recently
from
77b8c83 to
532a471
Compare
tequdev
reviewed
Dec 16, 2024
tequdev
reviewed
Dec 16, 2024
tequdev
reviewed
Dec 25, 2024
| if (!sto.has_value()) | ||
| returnJS(INVALID_ARGUMENT); | ||
|
|
||
| returnJS(__float_sto_set(hookCtx, applyCtx, j, sto->data(), sto->size())); |
There was a problem hiding this comment.
float_sto_set should return successful value as bigint(XFL)
Suggested change
| returnJS(__float_sto_set(hookCtx, applyCtx, j, sto->data(), sto->size())); | |
| int64_t const out = __float_sto_set(hookCtx, applyCtx, j, sto->data(), sto->size()); | |
| if (out < 0) | |
| returnJS(out); | |
| returnJSXFL(out); |
tequdev
reviewed
Jan 14, 2025
Comment on lines
+1433
to
+1438
| if (rt) | ||
| JS_FreeRuntime(rt); | ||
| if (ctx) | ||
| JS_FreeContext(ctx); | ||
| rt = NULL; | ||
| ctx = NULL; |
There was a problem hiding this comment.
In my environment, Object Leaks error occurred when running a local build, but changing it as suggested resolved the error.
Also, in the quickjs sample code, JS_FreeRuntime is called after JS_FreeContext, as suggested.
Suggested change
| if (rt) | |
| JS_FreeRuntime(rt); | |
| if (ctx) | |
| JS_FreeContext(ctx); | |
| rt = NULL; | |
| ctx = NULL; | |
| if (ctx) | |
| JS_FreeContext(ctx); | |
| if (rt) | |
| JS_FreeRuntime(rt); | |
| ctx = NULL; | |
| rt = NULL; |
tequdev
reviewed
Jan 15, 2025
Comment on lines
+1577
to
+1582
| int expr_len = | ||
| snprintf(expr, 256, "%s(%d)", | ||
| callback ? "Callback" : "Hook", | ||
| hookArgument); | ||
|
|
||
| if (expr_len < 7 || expr_len == 256) |
There was a problem hiding this comment.
This change makes it possible to do #332 Request 2.
Suggested change
| int expr_len = | |
| snprintf(expr, 256, "%s(%d)", | |
| callback ? "Callback" : "Hook", | |
| hookArgument); | |
| if (expr_len < 7 || expr_len == 256) | |
| int expr_len = | |
| snprintf(expr, 256, "%s(%d, otxn_json())", | |
| callback ? "Callback" : "Hook", | |
| hookArgument); | |
| if (expr_len < 20 || expr_len == 256) |
tequdev
reviewed
Jan 16, 2025
| uint32_t write_len) | ||
| DEFINE_JS_FUNCNARG( | ||
| JSValue, | ||
| hook_account); |
There was a problem hiding this comment.
Unnecessary semicolon
Suggested change
| hook_account); | |
| hook_account) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)