Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intents docs #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Intents docs #66

wants to merge 3 commits into from

Conversation

ronpandolfi
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #66 (345e97a) into master (5628c04) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   28.71%   28.69%   -0.02%     
==========================================
  Files          79       79              
  Lines        7286     7356      +70     
==========================================
+ Hits         2092     2111      +19     
- Misses       5194     5245      +51     
Impacted Files Coverage Δ
xicam/plugins/operationplugin.py 31.74% <ø> (ø)
xicam/gui/bluesky/databroker_catalog_plugin.py 27.36% <0.00%> (-11.92%) ⬇️
xicam/core/threads/__init__.py 50.00% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5628c04...345e97a. Read the comment docs.


### The Lifecycle of an Intent

A `GUIPlugin` that supports intents will contain a `CanvasManager`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need to explain what a canvas manager is? depends on how detailed we want the documentation to be here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate document for more advanced components

A `GUIPlugin` that supports intents will contain a `CanvasManager`.
Active intents will be rendered into a `Canvas` owned by the `CanvasManager`.
When an `Intent` is activated, the manager may generate a new `Canvas` for its rendering.
In cases such as co-plotting, a pre-existing `Canvas` may be used; that choice is based on the corresponding intents' `match_key` attributes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide example op of match_key

- ErrorBarIntent
- BarIntent

Although these types are primitive, additional specialized features can be added to them by specifying `mixin`'s.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is a mixin at a very high level? example of mixin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants