Skip to content

Commit

Permalink
ON-16235: continue tests on fail in GHA and expand slow test set
Browse files Browse the repository at this point in the history
I found that, during merging of the corresponding onload change, the
zfquiesce_waittw test failed so have added it to the slow tests. At
the same time, I spotted that I had accidentally dropped the -k from
the make test invocation to continue running through tests even if
one fails.
  • Loading branch information
jfeather-amd committed Jan 8, 2025
1 parent 8a1a9fa commit df630d2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/actions/test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ runs:
TIMEOUT_MULTIPLIER: ${{ inputs.test_timeout_multiplier }}
ZF_RUN_SLOW_TESTS: ${{ fromJSON(inputs.run_slow_tests) && 1 || 0 }}
ZF_DEVEL: 1
run: UT_OUTPUT="$GITHUB_STEP_SUMMARY" make -j $(nproc) test
run: UT_OUTPUT="$GITHUB_STEP_SUMMARY" make -j $(nproc) -k test
6 changes: 4 additions & 2 deletions src/tests/zf_unit/Makefile.inc
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ UT_OTHER := zftcppingpong2
UT_SCRIPTS := zfudppingpong.sh zf_tcp_sanity.sh packetdrill.sh zfsend.sh zfudpttl.sh

# List of tests to skip unless ZF_RUN_SLOW_TESTS=1 (defaults to 1)
# NOTE: `zfovl` is not actually slow, but rather unstable on slow machines.
# NOTE: Some tests are not actually slow, but rather unstable on slow machines:
# - `zfovl`
# - `zfquiesce_waittw`
UT_SLOW := zf_superbuf_fallback zf_superbuf_stack_destroy zf_superbuf_locality \
zf_superbuf_n_sleep zf_superbuf_sleepy_stacks zftcptimeouts \
zfreactorloop zfstackfree zfrxtable zftcprx zfovl
zfreactorloop zfstackfree zfrxtable zftcprx zfovl zfquiesce_waittw

# List of tests to skip unless ZF_RUN_UNSTABLE_TESTS=1 (defaults to 0)
UT_UNSTABLE := zftimestamping $(UT_SCRIPTS)
Expand Down

0 comments on commit df630d2

Please sign in to comment.