Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update ci to use github actions instead of gitlab #1

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Yag000
Copy link
Owner

@Yag000 Yag000 commented Feb 26, 2024

Pull Request

Description

Update the CI to run on this service :)

Changes Made

  • Removed gitlab stuff
  • Added corresponding github's equivalent

Checklist

  • I have self-reviewed my code
  • Code follows project's style guidelines
  • Tests added and passing
  • Documentation updated (if needed)

Copy link
Collaborator

@YanisLcn YanisLcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ! LGTM 👍

@Yag000
Copy link
Owner Author

Yag000 commented Feb 28, 2024

I've been testing this a little bit and I found some issues. The yml file must change since github does not like running on images other than some very spacial ones (<10), which means that I have to make a few minor tweaks. Apart from that there is a test that refuses to work (syncing issue I believe) so I'll have to give it a better look.

@Yag000 Yag000 marked this pull request as draft February 28, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants