Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Static Transform Broadcaster and publish flange->tool0 to newly created /tf_static topic #322

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jimmy-mcelwain
Copy link
Collaborator

@jimmy-mcelwain jimmy-mcelwain commented Oct 22, 2024

In reference to #20

@jimmy-mcelwain jimmy-mcelwain marked this pull request as draft October 22, 2024 19:27
@jimmy-mcelwain
Copy link
Collaborator Author

This successfully publishes flange->tool0 to tf_static, but I need to do more testing and probably clean it up

@gavanderhoorn
Copy link
Collaborator

Nice work.

A high-level comment and a question:

  • would there be a way to implement this without adding more static variables? Some of the added functions don't take any arguments but just edit static variables. I understand why you did that, but I'd suggest trying to move away from that pattern, as it facilitates testing (can just pass in 'test values') and reduces potential for problems.
  • is the bool check has-this-been-sent-yet really needed? I was hoping the static transform broadcaster would be smart enough to not broadcast transforms it's already seen, or we can just call send(..) once outside of the loop, right after the agent connected. It would be OK to republish in case of a dropped connection / a reconnect. tf_static is for 'never' changing transforms -- or things that change very infrequently, so republishing is acceptable.

@jimmy-mcelwain
Copy link
Collaborator Author

I will look at those suggestions. I added static variables because that is how it is done with the other PositionMonitor messages and publishers. I can probably switch off of static variables. As for the check has-this-been-sent-yet, I can probably find a better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants