Skip to content

Commit

Permalink
Merge pull request #1022 from Yelp/u/kkasp/pass-json-back-to-save-queue
Browse files Browse the repository at this point in the history
Pass json_val back to the save queue on failure
  • Loading branch information
KaspariK authored Jan 10, 2025
2 parents ca1037d + 946933a commit ff27ce0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions tron/serialize/runstate/dynamodb_state_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,8 @@ def _consume_save_queue(self):
except Exception as e:
error = "tron_dynamodb_save_failure: failed to save key " f'"{key}" to dynamodb:\n{repr(e)}'
log.error(error)
# Add items back to the queue if we failed to save. While we roll out and test TRON-2237 we will only re-add the Pickle.
# TODO: TRON-2239 - Pass JSON back to the save queue
with self.save_lock:
self.save_queue[key] = (val, None)
self.save_queue[key] = (val, json_val)
duration = time.time() - start
log.info(f"saved {saved} items in {duration}s")

Expand Down

0 comments on commit ff27ce0

Please sign in to comment.