Update delete_item logic to handle json partitions #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaspariK
commented
Jan 9, 2025
| assert_equal(num_partitions, 0) | ||
| assert_equal(num_json_val_partitions, 0) | ||
|
|
||
| def test_delete_item_with_json_partitions(self, store, small_object, large_object): |
There was a problem hiding this comment.
Hmm, maybe it would make more sense to test with the larger object here
There was a problem hiding this comment.
imo, we have both as fixtures in this test already so we could easily test with both :)
nemacysts
previously approved these changes
Jan 9, 2025
nemacysts
approved these changes
Jan 9, 2025
| assert_equal(num_partitions, 0) | ||
| assert_equal(num_json_val_partitions, 0) | ||
|
|
||
| def test_delete_item_with_json_partitions(self, store, small_object, large_object): |
There was a problem hiding this comment.
imo, we have both as fixtures in this test already so we could easily test with both :)
|
I'll add that last comment as a todo lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to update the logic for deleting items to account for a difference in partitions between pickles and json