Have attacker rerun all requests, update xfail test #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This semi-addresses #11) |
domanchi
suggested changes
Jan 6, 2020
…equests with different params
|
I ended up reverting the test that I modified, as after testing for a while I realized that it was flaky and I couldn't figure out why. |
domanchi
reviewed
Jan 8, 2020
domanchi
reviewed
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the attacker run all the requests with their own authorization. However, this has a flaw where the attacker may try to create duplicate objects, which would could cause an error to occur. I updated the existing xfail test to account for this.