Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search diagnostics to deadline exceeded exceptions #621

Merged
merged 6 commits into from
Feb 7, 2024
+67 −3
Merged

Add search diagnostics to deadline exceeded exceptions #621

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c24ba2f
Add search diagnostics to deadline exceeded exceptions
swekannan Feb 3, 2024
57aba44
Add search diagnostics to deadline exceeded exceptions
swekannan Feb 3, 2024
cd2c180
Create a separate deadline check method with diagnostics
swethakann Feb 5, 2024
b2cf5c4
Create a separate deadline check method with diagnostics
swethakann Feb 5, 2024
fc1e72e
nit
swethakann Feb 6, 2024
49b5137
Add test examples and log builder instead of built diagnostics
swethakann Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/com/yelp/nrtsearch/server/luceneserver/SearchHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ public SearchResponse handle(IndexState indexState, SearchRequest searchRequest)

diagnostics.setFirstPassSearchTimeMs(((System.nanoTime() - searchStartTime) / 1000000.0));

DeadlineUtils.checkDeadline("SearchHandler: post recall", "SEARCH");
DeadlineUtils.checkDeadline("SearchHandler: post recall, Search Diagnostics: " + diagnostics, "SEARCH");

// add detailed timing metrics for query execution
if (profileResultBuilder != null) {
Expand All @@ -206,7 +206,7 @@ public SearchResponse handle(IndexState indexState, SearchRequest searchRequest)
hits = rescorer.rescore(hits, searchContext);
long endNS = System.nanoTime();
diagnostics.putRescorersTimeMs(rescorer.getName(), (endNS - startNS) / 1000000.0);
DeadlineUtils.checkDeadline("SearchHandler: post " + rescorer.getName(), "SEARCH");
DeadlineUtils.checkDeadline("SearchHandler: post " + rescorer.getName() + ", Search Diagnostics: " + diagnostics, "SEARCH");
}
diagnostics.setRescoreTimeMs(((System.nanoTime() - rescoreStartTime) / 1000000.0));
}
Expand Down Expand Up @@ -287,7 +287,7 @@ public SearchResponse handle(IndexState indexState, SearchRequest searchRequest)
}

// if we are out of time, don't bother with serialization
DeadlineUtils.checkDeadline("SearchHandler: end", "SEARCH");
DeadlineUtils.checkDeadline("SearchHandler: end, Search Diagnostics: " + diagnostics, "SEARCH");
SearchResponse searchResponse = searchContext.getResponseBuilder().build();
if (!warming && searchContext.getIndexState().getVerboseMetrics()) {
VerboseIndexCollector.updateSearchResponseMetrics(
Expand Down
Loading