Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
TermStates.build()
concurrent, due to which the build method now needsIndexSearcher
instead ofIndexReaderContext
. [Backport] GITHUB-11838 Add api to allow concurrent query rewrite apache/lucene#12197 had added concurrent query rewrite and introducedrewrite(IndexSearcher)
, markingrewrite(IndexReader)
as deprecated. I have replaced allrewrite(IndexReader)
withrewrite(IndexSearcher)
to keep it consistent and so that we can callTermStates.build()
withIndexSearcher
.MultiSegmentTest
has a change in assertion because thetoString
changed, but not sure where. It might be due to change in the rewrite.SegmentInfo
has a newhasBlocks
parameter in constructor, so set it to false inBucketedTieredMergePolicyTest
.IndexReader
parameter fromFilterFunction.doRewrite()
since it was unused.Example plugin test fails because the jar is not uploaded yet.