Lucene 9.10 upgrade #626
Merged
Lucene 9.10 upgrade #626
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…topHits requested <= 0
…ctor if topHits requested <= 0" This reverts commit 0aa6e50.
aprudhomme
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache/lucene#12891 moved the check for hits <= 0 to the CollectorManager from Collector. This resulted in throwing an error for queries which request 0 hits, because we were creating the CollectorManager first and then checking the number of hits to retrieve. I have moved this check before the CollectorManager is created by making the code that computes number of hits to collect to a public static function.
Example plugin test fails because the jar is not uploaded yet.