enable defaultAwsCredentialChain when botoCfgPath is neglected #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The YelpReviews actually is a case where credentials and bucketname are both invalid. To keep consistency instead of throwing exceptions, we need to tolerate the AmazonS3Exception |
waziqi89
force-pushed
the
u/waziqi/RP-10149
branch
2 times, most recently
from
13d12e3 to
67a201c
Compare
waziqi89
force-pushed
the
u/waziqi/RP-10149
branch
from
00cf2fa to
643fe83
Compare
vim345
approved these changes
Mar 25, 2024
| + luceneServerConfiguration.getBucketName() | ||
| + ". This could be caused by missing credentials and/or regions, or wrong bucket name.", | ||
| sdkClientException); | ||
| logger.info("return a dummy AmazonS3."); |
There was a problem hiding this comment.
What's the trade off of using a dummy Amazon S3 client here?
There was a problem hiding this comment.
This is used to keep the consistency after making the changes. This is essential for some existing tests where the s3 settings is invalid.
https://github.com/Yelp/nrtsearch/pull/627/files#diff-37db6e5b57c28cce4fd4b60b04b1e1c8308668c90a4d5ec9d1ee6bac6becfe1aL53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RP-10149
botoCfgPathto be null