Close old reference manager when using filtering searcher manager #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarthakn7
reviewed
Mar 8, 2024
| @@ -121,7 +123,9 @@ public synchronized void start(long primaryGen) throws IOException { | |||
| // Swap in a SearcherManager that filters incompatible segment readers during refresh. | |||
| // Updating the reference is not thread safe, but since this happens under the object lock | |||
| // and before the shard has stared, nothing should access the manager before the swap. | |||
| ReferenceManager<IndexSearcher> oldMgr = mgr; | |||
| mgr = new FilteringSegmentInfosSearcherManager(getDirectory(), this, mgr, searcherFactory); | |||
There was a problem hiding this comment.
It appears as if FilteringSegmentInfosSearcherManager is using the old reference manager because it's passed in the constructor, but it only gets the current SegmentInfos: ((SegmentInfosSearcherManager) mgr).getCurrentInfos()
Can we change the constructor to accept SegmentInfos and then pass it from here so that it's clear that the old reference manager is not accessed any more?
There was a problem hiding this comment.
Unfortunately, SegmentInfosSearcherManager is package private and cannot be used from NRTReplicaNode unless we relocate the class.
sarthakn7
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
FilteringSegmentInfosSearcherManagerrequires replacing the reference to the defaultIndexSearcherReferenceManager. However, the previous reference manager was not being closed, which leaves a reference to the initial index segment readers.This branch fixes the issue by closing the old reference manager after it is replaced.