Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client:sourcesJar depend on generateProto task #630

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

sarthakn7
Copy link
Contributor

./gradlew publish was throwing an error without this.

A problem was found with the configuration of task ':clientlib:sourcesJar' (type 'Jar').
  - Gradle detected a problem with the following location: '/Users/sarthakn/IdeaProjects/nrtsearch/clientlib/build/generated/source/proto/main/java'.
    
    Reason: Task ':clientlib:sourcesJar' uses this output of task ':clientlib:generateProto' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':clientlib:generateProto' as an input of ':clientlib:sourcesJar'.
      2. Declare an explicit dependency on ':clientlib:generateProto' from ':clientlib:sourcesJar' using Task#dependsOn.
      3. Declare an explicit dependency on ':clientlib:generateProto' from ':clientlib:sourcesJar' using Task#mustRunAfter.

@sarthakn7 sarthakn7 requested a review from aprudhomme March 8, 2024 21:53
@sarthakn7 sarthakn7 merged commit ba4ab9c into 1.0.0-SNAPSHOT Mar 8, 2024
1 check failed
@sarthakn7 sarthakn7 deleted the sarthakn_add_dependsOn branch March 8, 2024 22:12
@sarthakn7 sarthakn7 restored the sarthakn_add_dependsOn branch March 8, 2024 22:12
@sarthakn7 sarthakn7 deleted the sarthakn_add_dependsOn branch March 8, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants