Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to lucene 10.1.0 #791

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

aprudhomme
Copy link
Contributor

@aprudhomme aprudhomme commented Nov 20, 2024

Update to lucene v10.1.0. Notable changes:

  • Do serialized initialization of MyIndexSearchers so that a single static can be used to distribute slicing parameters. Not much happens during initialization, so it shouldn't be much a performance issues (and we typically run few indices).
  • Removed override of search method in MyIndexSearcher, I don't think the reason for having this applies anymore.
  • Slicing of an index is only done at the segment level (like with lucene 9). We can experiment with exposing segment division as future work.
  • Vector data loading changed to use random access api.

@aprudhomme aprudhomme requested a review from sarthakn7 November 20, 2024 23:08
@aprudhomme aprudhomme marked this pull request as ready for review December 26, 2024 18:59
@aprudhomme aprudhomme changed the title Update to lucene 10.0.0 Update to lucene 10.1.0 Jan 3, 2025
Copy link
Contributor

@sarthakn7 sarthakn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly lgtm, just want to clarify one thing

}
}

@Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing these tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getPreload() method has been removed from MMapDirectory and there is no equivalent for the new system. Some of these tests are no longer possible to verify.

@aprudhomme aprudhomme merged commit e8772e1 into Yelp:main Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants