Fix sorting of single valued numeric fields #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make doc value range queries work correctly with single valued
FLOATandDOUBLEfields, the encoding was changed to be sortable. This causes a problem, since the standardSortFieldwill assume they are encoded as raw bits. This change usesSortedNumericSortFieldfor single and multi valued fields.This issue was missed because the current sort field tests did not include negative numbers. The tests have been modified to correct this. Additionally, tests have been added for multi valued numeric fields.
This does seem to cause an issue when trying to use a singled valued numeric field for index sorting, but I think we can fix this later and add better test coverage around this feature.
I'm starting to wonder if there is really a benefit to supporting single valued fields at all.