Skip to content

Commit

Permalink
Move testable service modes to reusable variable
Browse files Browse the repository at this point in the history
  • Loading branch information
jfongatyelp committed Jan 2, 2025
1 parent bc8fc5f commit 5a88ece
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion paasta_tools/cli/cmds/info.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
"Please add one that points to a reference doc for your service"
)

# modes that depend on smartstack port cannot be tested via paasta proxies, so we exclude those
TESTABLE_SERVICE_MODES = {"http", "https"}


def add_subparser(subparsers):
list_parser = subparsers.add_parser(
Expand Down Expand Up @@ -94,7 +97,7 @@ def get_deployments_strings(service: str, soa_dir: str) -> List[str]:
)
service_mode = service_config.get_mode()
for cluster in deployments_to_clusters(deployments):
if service_mode == "http" or service_mode == "https":
if service_mode in TESTABLE_SERVICE_MODES:
link = PaastaColors.cyan(
f"{service_mode}://{service}.proxy.{cluster}.paasta/"
)
Expand Down

0 comments on commit 5a88ece

Please sign in to comment.