let enable_automated_redeploys default value be configurable #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paasta get-image-versionwill output an empty string if the service has no deploy steps withenable_automated_redeploysenabled (for compatibility with pre-automated-redeploys behavior).This introduces a new system config
enable_automated_redeploys_default, itself defaulted to False, that controls whetherpaasta get-image-versiontreats a deploy step with no explicitenable_automated_redeploysas enabled or disabled.(If set to True this doesn't actually cause automated redeploys to happen, that requires separate additional Jenkins changes.)
Testing
I ran a random
paasta get-image-version -s <service> -c <commit>for a service with noenable_automated_redeploysspecified and confirmed that existing behavior continues (empty string with a stderr warning), and that you do get an image version ifenable_automated_redeploys_defaultis set to True.