Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backwards "Bouncing to" status #3989

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

jfongatyelp
Copy link
Contributor

We've been reporting which version we are "Bouncing to" incorrectly for quite some time.

Old status:

paasta-contract-monitor.main in eksstage (EKS)
    Version:    5f01b83e (desired)
    State: Bouncing to configd345863a <--- reports the config version from "(old)" version
    Running versions:
      Rerun with -v to see all replicas
      5f01b83e, config6df36c8b (new) - Started 2024-11-26 12:29:06 (21 seconds ago) <--- most recent version, the one we are actually bouncing to
        Replica States: 10 Warming Up
      5f01b83e, configd345863a (old) - Started 2024-11-06 09:09:05 (20 days ago)

With my change:

paasta-contract-monitor.main in eksstage (EKS)
    Version:    5f01b83e (desired)
    State: Bouncing to config6df36c8b
    Running versions:
      Rerun with -v to see all replicas
      5f01b83e, config6df36c8b (new) - Started 2024-11-26 12:29:06 (now)
        0 pods found
      5f01b83e, configd345863a (old) - Started 2024-11-06 09:09:05 (20 days ago)
        Replica States: 3 Healthy / 7 Warning

This also fixes the tests to actually catch this behavior, and verify earlier/later timestamps get sorted the way we want.

@jfongatyelp jfongatyelp requested a review from a team as a code owner November 26, 2024 20:31
Copy link
Member

@EvanKrall EvanKrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could also see just doing bouncing_to.append(versions[-1]....) if we want to keep newer versions on the bottom, but I don't particularly care which order the versions go in.

@EvanKrall
Copy link
Member

could also see just doing bouncing_to.append(versions[-1]....) if we want to keep newer versions on the bottom, but I don't particularly care which order the versions go in.

oh wait this versions variable only seems to be used to calculate the bouncing_to version

@jfongatyelp jfongatyelp merged commit f715cd8 into master Dec 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants