Disallow having service account + iam_role #3991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have to manage the service account (and its pod identity annotation) if someone specifies an
iam_role
for their instance, this is probably incompatible with specifying a service_account.Technically nothing would break with both, we just wouldn't do anything with the iam_role they'd provided and it would be more difficult for them to troubleshoot iam issues.
This will give a validation error like the following:
And for tron: