Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow having service account + iam_role #3991

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

jfongatyelp
Copy link
Contributor

@jfongatyelp jfongatyelp commented Dec 4, 2024

Since we have to manage the service account (and its pod identity annotation) if someone specifies an iam_role for their instance, this is probably incompatible with specifying a service_account.

Technically nothing would break with both, we just wouldn't do anything with the iam_role they'd provided and it would be more difficult for them to troubleshoot iam issues.

This will give a validation error like the following:
Screenshot 2024-12-04 at 11 27 25 AM

And for tron:
Screenshot 2024-12-04 at 1 10 31 PM

@jfongatyelp jfongatyelp requested a review from a team as a code owner December 4, 2024 19:29
nemacysts
nemacysts previously approved these changes Dec 4, 2024
Copy link
Member

@nemacysts nemacysts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, i think i brought this up once but i was a bad citizen and didn't fix or ticket this - thanks for being more diligent!

that said, the tron schema probably needs the same fix :)

@jfongatyelp jfongatyelp merged commit 1d25fb8 into master Jan 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants