Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scribereader imports to work with newer package #58

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Fix scribereader imports to work with newer package #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
584633a
Fix scribereader imports to work with newer package
jfongatyelp Jun 5, 2024
373ce3b
Add minimal clog/scribereader versions to yelp_internal requirements
jfongatyelp Jun 5, 2024
6f1ae43
whoops
jfongatyelp Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
],
extras_require={
'yelp_internal': [
'yelp-clog>=2.12.1',
'yelp-clog>=7.1.1',
'scribereader>=1.1.1',
'slo-transcoder>=3.2.3',
],
},
Expand Down
4 changes: 2 additions & 2 deletions sticht/slack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@

try:
from scribereader import scribereader
from clog.readers import construct_conn_msg
from clog.readers import find_tail_host
from scribereader.clog.readers import construct_conn_msg
from scribereader.clog.readers import find_tail_host
nemacysts marked this conversation as resolved.
Show resolved Hide resolved
except ImportError:
scribereader = None
construct_conn_msg = None
Expand Down
Loading