Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an app rejection list #2515

Merged
merged 12 commits into from
Aug 17, 2024
Merged

Implement an app rejection list #2515

merged 12 commits into from
Aug 17, 2024

Conversation

tituspijean
Copy link
Contributor

@tituspijean tituspijean commented Aug 15, 2024

Packagers are tired of repeating themselves.

Wishlist:

  • add a !reject *reason* keyword that automatically takes the diff and pushes it to rejectedlist.toml
  • add a link to the closed PR to read about the debates?

@OniriCorpe
Copy link
Member

OniriCorpe commented Aug 16, 2024

i think a rejection based on the source repo link would be better

@tituspijean

This comment was marked as outdated.

@tituspijean
Copy link
Contributor Author

tituspijean commented Aug 17, 2024

⬆️ untested, and I think there is some optimization to be done to differentiate the functions for the YunoHost-Apps organization and the ones for this repository.

I will try to add the webhook to this repository for debugging. 🤞

@tituspijean
Copy link
Contributor Author

Done, can be tested by reopen and playing with #2525 (needs to have rejectedlist.toml in the branch, so I pushed it in there)

Copy link
Member

@OniriCorpe OniriCorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, thanks for this great work ❤️

@tituspijean tituspijean merged commit 71800d2 into master Aug 17, 2024
5 checks passed
@tituspijean tituspijean deleted the rejectedlist branch August 17, 2024 23:52
Salamandar pushed a commit that referenced this pull request Sep 13, 2024
Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org>
Co-authored-by: OniriCorpe <oniricorpe@yunohost.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants