feature: Light mode #401
Merged
feature: Light mode #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carson-Shaar
previously approved these changes
Jan 11, 2025
Carson-Shaar
force-pushed
the
light-mode
branch
from
02ab8dc to
5bbdb11
Compare
Carson-Shaar
previously approved these changes
Jan 11, 2025
…403) chore(miantain-ui): Solve UI bugs in the theme changing for notebook
* chore(miantain-ui): Solve UI bugs in the theme changing for notebook * fix(light-theme-ui): Fixed issues with light theme UI --------- Co-authored-by: Red-Giuliano <44534590+Red-Giuliano@users.noreply.github.com>
Carson-Shaar
force-pushed
the
light-mode
branch
from
76daadf to
6a43587
Compare
Carson-Shaar
previously approved these changes
Jan 14, 2025
Carson-Shaar
approved these changes
Jan 14, 2025
Red-Giuliano
added a commit
that referenced
this pull request
Jan 23, 2025
* updated docs with higher res screenshots and to fix typos/errors in code * minor docs updates and saving/reading as python file * made slight change to handle multine cell definitions in parser * excluding notebook.py from reload in dev cli * notebook saves as a bunch of python functions * playing around with light theme * added zt_backend from master * light mode is roughly working... need to diff with main and refactor * removed custom theming for radio and text area * changes to support light mode * chore(miantain-ui): Solve UI bugs in the theme changing for notebook (#403) chore(miantain-ui): Solve UI bugs in the theme changing for notebook * fix(light-theme-ui): Fixed issues with light theme UI (#404) * chore(miantain-ui): Solve UI bugs in the theme changing for notebook * fix(light-theme-ui): Fixed issues with light theme UI --------- Co-authored-by: Red-Giuliano <44534590+Red-Giuliano@users.noreply.github.com> * restored yarn.lock * added types to fix build error * Delete zt_backend/utils/nb_python.py * removing conditional cell header render * fix: Bump test dependencies --------- Co-authored-by: Red Giuliano <red.giuliano@zero-true.com> Co-authored-by: Priya Kanabar <119392691+priyakanabar-crest@users.noreply.github.com> Co-authored-by: Carson-Shaar <carson.shaar@zero-true.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.