New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in rp2xxx pio assembler #346

Merged

mattnite merged 1 commit into ZigEmbeddedGroup:main from Grazfather:rp2xxx_pio_fix_assembler_error

Jan 9, 2025

Contributor

Grazfather commented Jan 6, 2025

If we ever hit an error case that didn't set diags, we'd error out incorrectly since compileError expects a string, not an error.


          Fix error handling in rp2xxx pio assembler

0a2d13c

Grazfather marked this pull request as ready for review

January 7, 2025 18:35

mattnite approved these changes

View reviewed changes

mattnite merged commit ff006c5 into ZigEmbeddedGroup:main

27 checks passed

Grazfather deleted the rp2xxx_pio_fix_assembler_error branch

January 10, 2025 04:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet