pio: Assembler: fix issue in diag when tokenizer has index on newline #347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tokenizer index is at the newline at the end of a line and it initializes the diagnostics, the column calculation will underflow, since the line iterator index will point to the end of the next line, while the index will be the previous new line character, so the column will be calculated as -1.
This change simply allows the index to point to the newline, though in this case the diagnostic will point past the end of the line: