Improve the 15m isochrone view, by coloring roads without any buildings #1075
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #669 for context on the problems. I've chatted about this problem with @tnederlof, @booboo18, @adam-jb, and @mfbenitezp before, so CC if y'all're interested!
The changes
Before:
After:
Before:
After:
I'm honestly not sure if this is an improvement or not. The new change fills in more gaps/holes when there are no buildings around, but there are still some unexplainable gaps.
Implementation
https://a-b-street.github.io/docs/software/fifteen_min.html#implementation is an overview how this works. The big picture is somewhat simple:
The change here is to not just populate squares based on building centroids. During the graph search, we cross road segments that have no buildings attached to them. When we do, also remember the cost to reach that road. Then we can walk along the road's center-line in 50m steps, find the 100x100 square, and fill out a cost value too.
Complications:
To visualize what's happening more clearly, we can just lower
resolution_m
to 10x10:You can see the blobs of green, yellow, and red filled out on building centroids, and in a few places, along a road segment with no matching buildings.
Feedback
Any ideas to improve this? Is there another isochrone / walkshed tool that has particularly easy-to-understand output, even in the presence of large empty water/green space?