-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON-LD trials #455
JSON-LD trials #455
Conversation
@VladimirAlexiev as far as I can see, you haven't committed any changes to the generator? If I understand correctly, you want to manually change the JSON-LD instead of generating it? If so, then this repository is the wrong place. The aas-core-codegen is a transpiler. Please have a look at this module which implements the generation of JSON-LD from a formalized meta-model: |
Hi @mristin ! Please merge the "trials" folder. It serves to document the round-tripping attempts, and the need for 2 changes to context. |
Please double-check, have you forgotten maybe to add files to the commit? I only see changes to The |
@mristin Move |
@VladimirAlexiev if there are no changes to the generator(s), then these files and documents simply don't belong to this repository. I suggest you either 1) create a separate repository, or 2) sync with the corresponding IDTA workgroup and put the files in their shared folder. |
@mristin So you have examples, and you have context, but you don't want to include examples of how the context works? Let me give an example from another standardization effort:
In this way I diagnosed hundreds of problems in the proposed Context. See one big cluster in gs1/EPCIS#307. |
@VladimirAlexiev I'm not saying that the examples are unnecessary -- this repository is simply not the place for them. This repository contains the code for automatic generation of different artefacts based on a formalized meta-model (not necessarily an AAS meta-model!). The examples you submitted are not the test data of the generators, but of the generated artefacts. They should live wherever you put the artefacts. Think of aas-core-codegen as a compiler. You do not put the unit tests for your source code in the compiler's repository. |
@ethieblin @wiresio @mristin
Described in admin-shell-io/aas-specs#386