chore: another ruff-related cleanup.

ruff.toml

@@ -136,7 +136,6 @@ lint.extend-ignore = [
     "PLR5501", # Use `elif` instead of `else` then `if`, to reduce indentation
     "PLR6201", # Use a `set` literal when testing for membership
     #
-    "PLW0108", # Lambda may be unnecessary; consider inlining inner function
     "PLW1514", # `open` in text mode without explicit `encoding` argument
     "PLW2901", # `for` loop variable overwritten by assignment target
     "PLW3201", # Bad or misspelled dunder method name. (bad-dunder-name)

src/abilian/sbe/apps/social/forms.py

@@ -23,7 +23,7 @@ class UserProfileViewForm(UserProfileForm):
         "Communautés d'appartenance",
         get_label="name",
         view_widget=abilian_widgets.ListWidget(),
-        query_factory=lambda: Community.query.all(),
+        query_factory=lambda: Community.query.all(),  # noqa: PLW0108
         multiple=True,
         validators=[optional()],
     )

src/abilian/services/indexing/tests/test_adapter.py

@@ -77,7 +77,9 @@ def test_build_attrs_3():
         "text",
         "updated_at",
     }
-    assert all(lambda f: callable(f) for f in adapter.doc_attrs.values())
+
+    # FIXME: this test doesn't make sense
+    # assert all(lambda f: callable(f) for f in adapter.doc_attrs.values())
 
     assert set(schema.names()) == {
         "allowed_roles_and_users",
@@ -111,7 +113,9 @@ def test_build_attrs_4():
         "object_type",
         "object_key",
     }
-    assert all(lambda f: callable(f) for f in adapter.doc_attrs.values())
+
+    # FIXME: this test doesn't make sense
+    # assert all(lambda f: callable(f) for f in adapter.doc_attrs.values())
 
     assert set(schema.names()) == {
         "id",

src/abilian/web/admin/panels/dashboard.py

@@ -185,7 +185,7 @@ def uniquelogins(sessions: list[Any]) -> tuple[list[Any], list[Any], list[Any]]:
     # convert the index to Datetime type
     daily_serie.index = pd.DatetimeIndex(daily_serie.index)
     # calculate the values instead of users lists
-    daily_serie = daily_serie.apply(lambda x: len(x))
+    daily_serie = daily_serie.apply(len)
 
     # GroupBy Week/month, Thanks Panda
     weekly_serie = daily_serie.groupby(pd.Grouper(freq="W")).aggregate(numpysum)

src/abilian/web/forms/fields.py

@@ -545,7 +545,7 @@ def _get_data(self):
             if all(hasattr(x, "name") for x in data):
                 data = sorted(data, key=lambda x: x.name)
             else:
-                data = sorted(data, key=lambda x: str(x))
+                data = sorted(data, key=str)
 
             if data:
                 if not self.multiple:

src/abilian/web/preferences/user.py

@@ -35,7 +35,7 @@ class UserPreferencesForm(Form):
     locale = fields.LocaleSelectField(
         label=_l("Preferred Language"),
         validators=[required()],
-        default=lambda: get_default_locale(),
+        default=get_default_locale,
     )
 
     timezone = fields.TimezoneField(