[ECO-4767] Fix server certificate verification #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-forooghian
force-pushed
the
ECO-4767-fix-tls-verification
branch
4 times, most recently
from
62afd51 to
80b79cf
Compare
lawrence-forooghian
added a commit
to ably/ably-ruby
that referenced
this pull request
Apr 25, 2024
|
(This is based on top of #1, which forks the library for Ably. That one is still a WIP but I think that this PR can be reviewed.) |
lawrence-forooghian
requested review from
sacOO7,
VeskeR,
ttypic and
umair-ably
umair-ably
approved these changes
Apr 26, 2024
sacOO7
requested changes
Apr 26, 2024
sacOO7
requested changes
Apr 26, 2024
lawrence-forooghian
force-pushed
the
create-ably-fork
branch
from
ee345b4 to
81e9f75
Compare
lawrence-forooghian
force-pushed
the
ECO-4767-fix-tls-verification
branch
from
80b79cf to
39dbd71
Compare
sacOO7
reviewed
Apr 26, 2024
lawrence-forooghian
force-pushed
the
create-ably-fork
branch
from
81e9f75 to
8e3ecd4
Compare
lawrence-forooghian
force-pushed
the
ECO-4767-fix-tls-verification
branch
from
39dbd71 to
2862fbf
Compare
lawrence-forooghian
force-pushed
the
ECO-4767-fix-tls-verification
branch
from
2862fbf to
9996b7b
Compare
graham-russell
approved these changes
May 3, 2024
lawrence-forooghian
added a commit
to ably/ably-ruby
that referenced
this pull request
May 15, 2024
See ably-forks/em-http-request#2. This fixes the internet-up check and hence the fallback hosts mechanism. Resolves #396.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ably/ably-ruby#396. See code comment for details.