Understand RSpec segfault #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-forooghian
force-pushed
the
understand-rspec-segfault
branch
3 times, most recently
from
7537b85 to
9c32865
Compare
The aim of this helper is to cause some tests to be skipped if there is no Internet connection. For some reason (which I haven’t investigated) when run on GitHub Actions these tests are always being skipped, causing me to not notice the test failures fixed in 139a59b. I am happy to remove this check; presumably if there’s no Internet connection then the affected tests will just fail, and that’s fine by me. I understand the intent of the author in adding this helper, and understand that being able to run some of the test suite offline may be a desirable thing, but I think not at the cost of it hiding failing tests by default. (There’s also a requires_port helper which is only used in the proxy-related tests; in order to remove that one we’d need to start running proxies locally and in CI, and I don’t want to spend time on that now. We don’t make use of this library’s proxy functionality in ably-ruby.)
This reverts commit 9996b7b.
lawrence-forooghian
force-pushed
the
understand-rspec-segfault
branch
from
9c32865 to
1edfedc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.