Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHG] Support for application/octet-stream #588

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shaenn
Copy link

@Shaenn Shaenn commented Aug 18, 2023

Hello,
Good job, for all, it's an amazing lib.

In my work, I use application/octet-stream for downloading file, but the parameter format wasn't set to 'blob'.

I can add a content-type image/png, but it's not really good, but it work...

I make this PR to resvolve this.

Best regards, Shaenn

application/octet-stream must be set format: 'blob'
@planetdaz
Copy link

I could really use this too. My API Produces a content-type of application/pdf but the generated api request is setting to a format of json when it needs to be blob.

Note: I'm using Axios, is there a way for me to override this format to get a requestType of 'blob'?

Thanks!

@smorimoto smorimoto requested a review from Copilot December 28, 2024 17:34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/schema-routes/schema-routes.js:320

  • Ensure that the new behavior for handling 'application/octet-stream' content type is covered by tests.
_.some(contentTypes, (contentType) => _.includes(contentType, 'application/octet-stream'))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants