Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge names (closes #4428) #4432

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Merge names (closes #4428) #4432

wants to merge 3 commits into from

Conversation

mjpost
Copy link
Member

@mjpost mjpost commented Jan 18, 2025

No description provided.

@mjpost mjpost self-assigned this Jan 18, 2025
@mjpost mjpost linked an issue Jan 18, 2025 that may be closed by this pull request
3 tasks
Copy link
Contributor

@nschneid nschneid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that starting on line 26 the list is alphabetical by canonical last name. But the initial entries are not. Won't affect site behavior but might be worth changing for uniformity.

@mjpost
Copy link
Member Author

mjpost commented Jan 18, 2025

Yeah, it's a bit cumbersome to sort alphabetically because the entries don't line up. I've resorted to top-of-the-file edits out of laziness and a sense that this file will change drastically when we address #623 properly.

Copy link

Build successful. Some useful links:

This preview will be removed when the branch is merged.

@mjpost
Copy link
Member Author

mjpost commented Jan 18, 2025

It seems we had a script for this. I ran it, many were mis-ordered. I did some spot checking that entries weren't removed. We'll see if the site builds.

@mbollmann
Copy link
Member

Yeah, it's a bit cumbersome to sort alphabetically because the entries don't line up. I've resorted to top-of-the-file edits out of laziness and a sense that this file will change drastically when we address #623 properly.

...and/or if these edits could be made easily through the Python module, hopefully soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author Page: zeerak-waseem
3 participants