Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-3281: Refactor Drupal recommended settings and add tests. #16

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

rajeshreeputra
Copy link
Contributor

Motivation
Fixes #ACMS-3281

Proposed changes

Alternatives considered

Testing steps

@rajeshreeputra rajeshreeputra changed the base branch from main to refactor-code November 10, 2023 06:13
composer.json Outdated Show resolved Hide resolved
@rajeshreeputra rajeshreeputra changed the title ACMS-3281: Refactor Drupal recommended settings. ACMS-3281: Refactor Drupal recommended settings and add tests. Nov 10, 2023
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chandan-singh7929 chandan-singh7929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall all changes looks good to me, there's minor suggestion please check

tests/unit/SettingsTest.php Outdated Show resolved Hide resolved
tests/unit/SettingsTest.php Show resolved Hide resolved
@vishalkhode1 vishalkhode1 merged commit 6c55be0 into refactor-code Nov 20, 2023
2 checks passed
@vishalkhode1 vishalkhode1 deleted the ACMS-3281 branch November 20, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants