-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACMS-3281: Refactor Drupal recommended settings and add tests. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshreeputra
requested review from
chandan-singh7929,
vishalkhode1,
apathak18 and
deepakmishra2
November 10, 2023 06:13
rajeshreeputra
force-pushed
the
ACMS-3281
branch
from
November 10, 2023 10:45
f3a1c33
to
2d2e246
Compare
rajeshreeputra
changed the title
ACMS-3281: Refactor Drupal recommended settings.
ACMS-3281: Refactor Drupal recommended settings and add tests.
Nov 10, 2023
apathak18
reviewed
Nov 14, 2023
apathak18
approved these changes
Nov 14, 2023
chandan-singh7929
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall all changes looks good to me, there's minor suggestion please check
rajeshreeputra
force-pushed
the
ACMS-3281
branch
from
November 14, 2023 12:25
50d705c
to
8a87c2c
Compare
rajeshreeputra
force-pushed
the
refactor-code
branch
from
November 15, 2023 09:07
8a85547
to
724e59d
Compare
rajeshreeputra
force-pushed
the
ACMS-3281
branch
from
November 15, 2023 09:08
8a87c2c
to
f922df5
Compare
chandan-singh7929
approved these changes
Nov 15, 2023
rajeshreeputra
force-pushed
the
ACMS-3281
branch
from
November 16, 2023 08:22
f922df5
to
38495a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #ACMS-3281
Proposed changes
Alternatives considered
Testing steps