Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 imp product origin improvements 2 #8

Conversation

legalsylvain
Copy link

Various improvment :

  • a7d97da [IMP] add state_id_domain on product.product model, to dynamically compute state_id domain
  • 2fbb678 [IMP] add state_id_domain on product.template model, to dynamically compute state_id domain
  • 448e817 [FIX] Do not display country_id and state_id on template form view if there are many variants
  • 26f9581 [FIX] typo in the name of the constrains function
  • b0557bd[FIX] also set constrains on product.template model.
  • ec0f78f [IMP] Add test

@legalsylvain
Copy link
Author

legalsylvain commented Jan 11, 2024

Hi @acsonefho. I made some improvment on the module product_origin you migrated here. (pending PR : OCA#1389)
Could you take a look on this one ?

thanks !

Note : pre-commit fail for unrelated reason. I guess acsone source branch should be rebased.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (16.0-mig-product_origin@9b9e325). Click here to learn what that means.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             16.0-mig-product_origin       #8   +/-   ##
==========================================================
  Coverage                           ?   93.53%           
==========================================================
  Files                              ?      207           
  Lines                              ?     3201           
  Branches                           ?      351           
==========================================================
  Hits                               ?     2994           
  Misses                             ?      139           
  Partials                           ?       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legalsylvain legalsylvain force-pushed the 16.0-IMP-product_origin-improvements-2 branch from 46a1e52 to e516a7e Compare January 11, 2024 13:54
@legalsylvain legalsylvain marked this pull request as draft January 11, 2024 17:57
@legalsylvain legalsylvain force-pushed the 16.0-IMP-product_origin-improvements-2 branch from e516a7e to 3f8a635 Compare January 11, 2024 20:54
@legalsylvain legalsylvain marked this pull request as ready for review January 11, 2024 22:22
Copy link

@acsonefho acsonefho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💪

@acsonefho acsonefho merged commit 6de366e into acsone:16.0-mig-product_origin Jan 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants