Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI and fix missing assertions #923

Merged

Conversation

tagliala
Copy link
Contributor

Backport some changes from 7.2 branch.

  • Use only value for Ruby versions to reduce complexity
  • Rename deps to rails for parity with Arbre and Active Admin gems

Close #922

Backport some changes from 7.2 branch.

- Use only value for Ruby versions to reduce complexity
- Rename `deps` to `rails` for parity with Arbre and Active Admin gems

Close activeadmin#922
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (a8cd775) to head (cc9b261).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   98.91%   98.91%           
=======================================
  Files          14       14           
  Lines         555      555           
=======================================
  Hits          549      549           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javierjulio javierjulio self-requested a review June 13, 2024 13:57
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit dbb10ba into activeadmin:master Jun 13, 2024
18 checks passed
@tagliala tagliala deleted the chore/922-improve-ci-and-specs branch June 13, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing assertions (Rails 7.2 warning)
2 participants