-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wing bank icon #1211
base: master
Are you sure you want to change the base?
Wing bank icon #1211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you add a border of #000 with 7% opacity and put your file through SVGO to reduce file size
@Lydia-shan-git Could you please take a look at the updated icon? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're still missing a background and border. Follow the these guidelines when resubmitting your icon. https://github.com/activemerchant/payment_icons/blob/master/CONTRIBUTING.md
@Lydia-shan-git I have updated the svg please gothrough for feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border colour should be #000 and 7% opacity and 1px thick in width with a 2px radius. All laid out in our guidelines
@Lydia-shan-git only 2px radius needs to be fixed. I had fixed it please share your feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border colour should be #000 and 7% opacity and 1px thick in width with a 2px radius. All laid out in our guidelines
@Lydia-shan-git please share your feedback |
@dannye0231 1 workflow is awaiting for approval |
@SyedAzeemAbbas Just double checking that you meant to have different border radius between the card icon and the card border |
border radius between the card icon and the card border fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in Gemfile.lock are not required as we'll take care of that during the merge process. Please remove these changes.
reverted as in master
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?