Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run tests on MSRV #250

Merged
merged 2 commits into from
May 25, 2022
Merged

Do not run tests on MSRV #250

merged 2 commits into from
May 25, 2022

Conversation

JohnTitor
Copy link
Member

PR Type

Chore

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

Spawned from #248 (comment)
The possible cons is we cannot detect version differences on tests but I don't feel it's the case we should care about.
Also, upgrades checkout action to v3, which includes an internal runtime version change, and the runner provided by GitHub shouldn't have any visible effect.

@JohnTitor JohnTitor requested a review from robjtede May 25, 2022 12:34
@robjtede robjtede merged commit f6508f2 into actix:master May 25, 2022
@JohnTitor JohnTitor deleted the ci-tweak branch May 25, 2022 13:12
@robjtede robjtede added the A-meta project organisation label Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta project organisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants