Turn off remote wakeup in USB configuration descriptor #4517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the "Remote Wakeup" bit turned on in the USB configuration descriptor we send to the host. This is problematic for two reasons:
tud_remote_wakeup()
at appropriate times, per @hathach.Some MicroPython folks noted problems due to Remote Wakeup being on for the RP2040, and turned it off: micropython#7085. See also raspberrypi/pico-sdk#289. We should do the same.
@hathach remarked to me in a side conversation that this is less of a problem in CircuitPython because of constant USB activity due to MSC. However, the host can still go to sleep after a while, and if MSC is disabled (e.g. for an HID appliance), then it would be more of an issue.
This may solve #4164 and #4190.