New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor optimizations #13

Open

syndbg wants to merge 3 commits into adambutler:master from syndbg:minor_optimizations

syndbg commented Oct 14, 2015

Updated Ruby and Rails versions
Set up Rubocop (https://github.com/bbatsov/rubocop).
Ran an Rubocop autocorrect to automagically fix issues (rubocop -a)
Added indices to the most used table columns in queries
Modified controller queries to raise ActiveRecord::NotFound exceptions. In RAILS_ENV=production this will show a 404 page

Addresses #12 in 4th bullet

syndbg added 3 commits

October 14, 2015 21:23


          Setup Rubocop and autocorrect offences

5547c72


          Add indices for better performance

e9d90d3


          Return 404 on ActiveRecord not found instead of 500

b01d1cd

syndbg force-pushed the minor_optimizations branch from 1d68ecc to b01d1cd Compare

October 16, 2015 17:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet