Add support for azurerm_virtual_machine #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An azurerm_network_interface must be defined and associated with the VM. Only supports loading private IP addresses. If the nic has multiple IP addresses defined, it will use the first one (read from private_ip_address). This is the primary IP address according to documentation. If there are multiple nics defined for the VM, the nic declared as the primary nic (via primary_network_interface_id) will be used.
adammck
requested changes
Apr 2, 2018
| @@ -163,6 +193,13 @@ func (r Resource) NameWithCounter() string { | |||
|
|
|||
| // Address returns the IP address of this resource. | |||
| func (r Resource) Address() string { | |||
|
|
|||
| switch r.resourceType { | |||
| case azureNicResourceKey, azureVMResourceKey: | |||
There was a problem hiding this comment.
- Pretty weird to be using a switch for this; there's only a single case.
- This part should go below the TF_KEY_NAME check, otherwise Azure resources won't be able to use that feature. Put it inside the
else, or refactor the method if you'd like. - Since AzureAddress() returns an empty string for non-azure resources, we could just always call it and return early if it returns a non-empty string.
| @@ -177,3 +214,30 @@ func (r Resource) Address() string { | |||
|
|
|||
| return "" | |||
| } | |||
|
|
|||
| func (r Resource) AzureAddress() string { | |||
There was a problem hiding this comment.
Please add a docstring to this method.
| @@ -146,6 +167,15 @@ func (r Resource) Tags() map[string]string { | |||
| t[kk] = vv | |||
| } | |||
| } | |||
| case "azurerm_virtual_machine": | |||
There was a problem hiding this comment.
Should we be using azureVMResourceKey here?
| // Everytime we encounter an azurerm_network_interface we will store the IP address | ||
| // in this map with the NIC id as the key. Then when we are looking for the VM address | ||
| // we'll check if the VM's (primary) NIC exists in the map. | ||
| var azureNICPrimaryIps map[string]string |
There was a problem hiding this comment.
I really don't like this global mutable map of things. Could we eliminate by either doing the lookup lazily (i.e. re-scanning the entire struct when looking up IPs for Azure VMs), or make it a member of some other object (probably state)?
|
Hello, |
|
@adammck Any chance this will get closed off? I don't mind getting involved and making any changes to the PR if that will help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An azurerm_network_interface must be defined and associated with
the VM. Only supports loading private IP addresses. If the nic
has multiple IP addresses defined, it will use the first one
(read from private_ip_address). This is the primary IP address
according to the Azure documentation.
If there are multiple nics defined for the VM, the nic declared
as the primary nic (via primary_network_interface_id) will be used.