Added provider emote id in returned emote json #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Creating unique key or filename for each of the emote (for emotes like "Harambe" it's ok, but what for ":)" where ":" character is invalid for a filename)
Possible solution:
Parsing the unique key from the URL of the emote. However, it's time-consuming and what if the URL changes?
Simple solution:
I propose in this pull request just passing emotes ID returned by twitch/7tv/bttv/ffz to the Emote object, so it can be returned by tEmotes API. This way, unique keys (or file names) for each emotes can be easily created by combining its ID and the provider's name (for example: 60ae7316f7c927fad14e6ca2_7tv.webp)
I hope this will be accepted as these IDs can come in handy for anyone using the tEmotes API :)