Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAS V3.0 Classes and Attribute Identifiers #31

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

AAS V3.0 Classes and Attribute Identifiers #31

wants to merge 65 commits into from

Conversation

sebbader-sap
Copy link
Contributor

No description provided.

@sebbader-sap sebbader-sap changed the title AAS V3 Classes and Attribute Identifiers AAS V3.0 Classes and Attribute Identifiers Nov 25, 2024
@BirgitBoss BirgitBoss self-requested a review November 25, 2024 14:02
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 25, 2024
View reviewed changes
aas/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 29, 2024
View reviewed changes
aas/API/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 29, 2024
View reviewed changes
aas/API/3/0/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 29, 2024
View reviewed changes
aas/API/3/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 29, 2024
View reviewed changes
aas/API/3/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 29, 2024
View reviewed changes
aas/API/3/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Nov 29, 2024
View reviewed changes
aas/API/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss requested changes Nov 29, 2024
View reviewed changes
Copy link

@BirgitBoss BirgitBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes, see comments - mainly titles and names

BirgitBoss and others added 14 commits November 29, 2024 17:48
@BirgitBoss
Merge branch 'aas-v3' into BiBo/ids_for_v3.0_branchSebB
b766eaa
@sebbader-sap @BirgitBoss
Update aas/API/3/0/README.md
708f672 
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
@sebbader-sap @BirgitBoss
Update aas/API/3/0/README.md
adb9273 
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
@sebbader-sap @BirgitBoss
Update aas/API/3/0/README.md
9990d81 
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
@sebbader-sap @BirgitBoss
Update aas/API/3/0/README.md
4378d9a 
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
@sebbader-sap @BirgitBoss
Update aas/API/3/0/README.md
eb7b3c8 
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
@sebbader-sap @BirgitBoss
Update aas/API/README.md
4fa2a10 
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
@sebbader-sap @BirgitBoss
Update aas/API/3/README.md
9b37bfc 
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
@sebbader-sap @BirgitBoss
Update aas/API/3/README.md
781fedb 
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
@sebbader-sap @BirgitBoss
Update aas/API/3/0/README.md
9f47ae3 
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
@sebbader-sap @BirgitBoss
Update aas/API/3/0/README.md
d43d08a 
Co-authored-by: Birgit Boss <59824205+BirgitBoss@users.noreply.github.com>
@sebbader-sap
remove the release candidate versions of the aas api classes
b9c9731
@sebbader-sap
fix references and contacts for aas and aas api
8d82988
@sebbader-sap
Merge pull request #32 from admin-shell-io/BiBo/ids_for_v3.0_branchSebB
0f51f5b 
remove data specification physical unit
missing classes etc.
BirgitBoss
BirgitBoss requested changes Nov 29, 2024
View reviewed changes
aas/3/0/README.md Outdated

[https://admin-shell.io/DataSpecificationTemplates/DataSpecificationIEC61360/3/0/DataTypeIEC61360](https://admin-shell.io/DataSpecificationTemplates/DataSpecificationIEC61360/3/0/DataTypeIEC61360) The DataTypeIEC61360 class as defined in IDTA-01003-a-3-0.

## DataTypeIEC61360/BOOLEAN_IEC6360_DATATYPE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IEC61360 not IEC6360: for all values

Why do we add _IEC61360 and DATATYPE at all? The enumeration vale is just BOOLEAN?

https://admin-shell-io.github.io/aas-specs-antora/IDTA-01003-a/v3.1/specification.html#_enumeration_data_type_iec61360

aas/3/0/README.md Outdated
Reference to the asset the entity is representing.

[http://admin-shell.io/aas/3/0/Entity/globalAssetId](http://admin-shell.io/aas/3/0/Entity/globalAssetId) The attribute globalAssetId of the Entity class as defined in IDTA-01001-3-0.
## Entity/specificAssetId
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty line

aas/3/0/README.md
Single extension of an element.

[https://admin-shell.io/aas/3/0/Extension](https://admin-shell.io/aas/3/0/Extension) The Extension class as defined in IDTA-01001-3-0.
## Extension/name
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty line

aas/3/0/README.md Outdated
[http://admin-shell.io/aas/3/0/Identifier/idType](http://admin-shell.io/aas/3/0/Identifier/idType) The attribute idType of the Identifier class as defined in IDTA-01001-3-0.


## IdentifierType
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IdentifierType and its values not part of spec any longer: remove

aas/3/0/README.md Outdated
[http://admin-shell.io/aas/3/0/IdentifierType/IRI](http://admin-shell.io/aas/3/0/IdentifierType/IRI) The IdentifierType IRI of the IdentifierType class as defined in IDTA-01001-3-0.


## IdentifierKeyValuePair
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not existing any longer

aas/3/0/README.md
Data type of the value attribute.

[https://admin-shell.io/aas/3/0/Property/valueType](https://admin-shell.io/aas/3/0/Property/valueType) The attribute valueType of the Property class as defined in IDTA-01001-3-0.
## Qualifiable
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add empty line

aas/3/README.md
Currently, one revision is in place as a Release Candidate. The major release
version 3.0 will be published soon:
This location contains the revisions of the third version of the AAS Metamodel, including its minor revisions.
Currently, one revision is in place as a Release Candidate.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, 3/0 is no release candidate

aas/API/README.md Show resolved Hide resolved
aas/README.md Outdated


[1] B. Boss, M. Hoffmeister, T. Deppe, F. Pethig, E. Barnstedt et al.
['Details of the Asset Administration Shell Part 1, The exchange of information
[1] ['Details of the Asset Administration Shell Part 1, The exchange of information
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use correct naming

aas/README.md Outdated
[4] B. Boss, M. Hoffmeister, T. Deppe, F. Pethig, S. Bader, E. Barnstedt et al.
['Details of the Asset Administration Shell Part 1, The exchange of information
between partners in the value chain of Industrie 4.0'](https://www.plattform-i40.de/IP/Redaktion/EN/Downloads/Publikation/Details_of_the_Asset_Administration_Shell_Part1_V3.html), Version 3.0.RC01,
[4] ['Details of the Asset Administration Shell Part 1, The exchange of information
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use correct title

BirgitBoss
BirgitBoss reviewed Dec 14, 2024
View reviewed changes
aas/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Dec 14, 2024
View reviewed changes
aas/README.md Outdated Show resolved Hide resolved
BirgitBoss
BirgitBoss reviewed Dec 14, 2024
View reviewed changes
aas/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BirgitBoss BirgitBoss BirgitBoss requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebbader-sap @BirgitBoss