Skip to content

Commit

Permalink
Build optimized wheels by default. Don't use -O3 because it fails build
Browse files Browse the repository at this point in the history
  • Loading branch information
juliannguyen4 committed Sep 22, 2023
1 parent cc25b5d commit b34ad9f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
12 changes: 0 additions & 12 deletions .github/workflows/build-wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,6 @@ jobs:
run: echo "CFLAGS=-O0 -g" >> $GITHUB_ENV
if: ${{ inputs.optimized-or-debug == 'debug' }}

- name: Set optimized flags
run: echo "CFLAGS=-O1" >> $GITHUB_ENV
if: ${{ inputs.optimized-or-debug == 'optimized' }}

- name: Build wheel
uses: pypa/cibuildwheel@v2.11.2
env:
Expand Down Expand Up @@ -248,10 +244,6 @@ jobs:
run: echo "CFLAGS=-O0 -g" >> $GITHUB_ENV
if: ${{ inputs.optimized-or-debug == 'debug' }}

- name: Set optimized flags
run: echo "CFLAGS=-O1" >> $GITHUB_ENV
if: ${{ inputs.optimized-or-debug == 'optimized' }}

- name: Build wheel
uses: pypa/cibuildwheel@v2.11.2
env:
Expand Down Expand Up @@ -286,10 +278,6 @@ jobs:
run: echo "CFLAGS=-O0 -g" >> $GITHUB_ENV
if: ${{ inputs.optimized-or-debug == 'debug' }}

- name: Set optimized flags
run: echo "CFLAGS=-O1" >> $GITHUB_ENV
if: ${{ inputs.optimized-or-debug == 'optimized' }}

- name: Build wheel
uses: pypa/cibuildwheel@v2.11.2
env:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
['/usr/local/opt/openssl/include'] + \
['aerospike-client-c/modules/common/src/include']
extra_compile_args = [
'-std=gnu99', '-Wall', '-fPIC', '-DDEBUG',
'-std=gnu99', '-Wall', '-fPIC', '-DDEBUG', '-O1',
'-fno-common', '-fno-strict-aliasing', '-Wno-strict-prototypes',
'-D_FILE_OFFSET_BITS=64', '-D_REENTRANT',
'-DMARCH_' + machine,
Expand Down

0 comments on commit b34ad9f

Please sign in to comment.