[CLIENT-2217] macOS wheels: update OpenSSL dependency from 1.1.1 to 3 #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #471 +/- ##
==========================================
- Coverage 80.89% 80.87% -0.02%
==========================================
Files 100 100
Lines 15053 15047 -6
==========================================
- Hits 12177 12170 -7
- Misses 2876 2877 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
juliannguyen4
force-pushed
the
CLIENT-2217-openssl3
branch
2 times, most recently
from
957b2a5 to
a87ca89
Compare
juliannguyen4
force-pushed
the
CLIENT-2217-openssl3
branch
from
21af794 to
de6779c
Compare
juliannguyen4
changed the title
justinlee-aerospike
requested changes
Nov 1, 2024
BUILD.md
Outdated
| @@ -87,8 +87,7 @@ By default macOS will be missing command line tools. | |||
|
|
|||
| The dependencies can be installed through the macOS package manager [Homebrew](http://brew.sh/). | |||
|
|
|||
| brew install openssl@1 | |||
| # brew uninstall openssl@3 | |||
| brew uninstall openssl@3 | |||
There was a problem hiding this comment.
do you mean 'install', not 'uninstall'?
justinlee-aerospike
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS arm64 and x86_64 wheels build and pass testing