Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-2551] Add Python 3.12 support #511

Merged
merged 12 commits into from
Feb 16, 2024
Merged

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Sep 13, 2023

Description

Many of the changes were cherry-picked / adopted from the v14-backport branch

Testing Python 3.12 in pipeline

PR Pre-merge tests: https://github.com/aerospike/aerospike-client-python/actions/runs/7933902194
Build wheels: https://github.com/aerospike/aerospike-client-python/actions/runs/7923859610
Test-server-rc: https://github.com/aerospike/aerospike-client-python/actions/runs/7933902714
Stage tests: https://github.com/aerospike/aerospike-client-python/actions/runs/7923867619

Extra changes

  • Trigger tests.yml for pushes and PRs to dev and v*-backport branches
  • Add option to test server RC on manual run of tests.yml
  • Remove Python 3.7 from .build.yml (QE cat 2 tests)
  • Allow dev-workflow-p1.yml to be run manually
  • Add option to skip build-wheels tests when running dev-workflow-p1.yml manually
  • Remove psutil from tests which was causing QE tests to not run

TODO: make guide on how to add support for new python versions in CI/CD pipeline

@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2551-python-3.12 branch from 66e0a23 to e99fb65 Compare September 13, 2023 23:22
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (611bdb6) 81.38% compared to head (ad671b8) 81.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #511   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files          98       98           
  Lines       14911    14911           
=======================================
  Hits        12136    12136           
  Misses       2775     2775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2551-python-3.12 branch 3 times, most recently from 5f07484 to f799004 Compare September 14, 2023 15:41
@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2551-python-3.12 branch from 3b8753b to d38fe03 Compare December 6, 2023 22:40
@juliannguyen4 juliannguyen4 changed the base branch from stage to dev February 15, 2024 23:04
@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2551-python-3.12 branch from d38fe03 to 87ff531 Compare February 15, 2024 23:38
@juliannguyen4 juliannguyen4 force-pushed the CLIENT-2551-python-3.12 branch from c22379a to b5cdf54 Compare February 16, 2024 15:31
@juliannguyen4 juliannguyen4 added the new-server-features Test against the latest server release candidate label Feb 16, 2024
@juliannguyen4 juliannguyen4 removed the new-server-features Test against the latest server release candidate label Feb 16, 2024
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 marked this pull request as ready for review February 16, 2024 23:08
@juliannguyen4 juliannguyen4 merged commit a32d614 into dev Feb 16, 2024
98 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-2551-python-3.12 branch February 16, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants