-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT-2551] Add Python 3.12 support #511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliannguyen4
force-pushed
the
CLIENT-2551-python-3.12
branch
from
September 13, 2023 23:22
66e0a23
to
e99fb65
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #511 +/- ##
=======================================
Coverage 81.38% 81.38%
=======================================
Files 98 98
Lines 14911 14911
=======================================
Hits 12136 12136
Misses 2775 2775 ☔ View full report in Codecov by Sentry. |
juliannguyen4
force-pushed
the
CLIENT-2551-python-3.12
branch
3 times, most recently
from
September 14, 2023 15:41
5f07484
to
f799004
Compare
juliannguyen4
force-pushed
the
CLIENT-2551-python-3.12
branch
from
December 6, 2023 22:40
3b8753b
to
d38fe03
Compare
…; remove unused memory leak test
juliannguyen4
force-pushed
the
CLIENT-2551-python-3.12
branch
from
February 15, 2024 23:38
d38fe03
to
87ff531
Compare
juliannguyen4
force-pushed
the
CLIENT-2551-python-3.12
branch
from
February 16, 2024 15:31
c22379a
to
b5cdf54
Compare
juliannguyen4
added
the
new-server-features
Test against the latest server release candidate
label
Feb 16, 2024
juliannguyen4
removed
the
new-server-features
Test against the latest server release candidate
label
Feb 16, 2024
justinlee-aerospike
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many of the changes were cherry-picked / adopted from the v14-backport branch
Testing Python 3.12 in pipeline
PR Pre-merge tests: https://github.com/aerospike/aerospike-client-python/actions/runs/7933902194
Build wheels: https://github.com/aerospike/aerospike-client-python/actions/runs/7923859610
Test-server-rc: https://github.com/aerospike/aerospike-client-python/actions/runs/7933902714
Stage tests: https://github.com/aerospike/aerospike-client-python/actions/runs/7923867619
Extra changes
dev
andv*-backport
branchesTODO: make guide on how to add support for new python versions in CI/CD pipeline